Line break for links appends the following text to the link

Sat, 12 Oct 2024 01:36:13 +0200

adminsforum@hubzilla.org

Markus wrote the following post Sat, 12 Oct 2024 01:36:14 +0200

Line break for links appends the following text to the link

When writing posts, I have noticed that as soon as I insert a link, the following text is appended to the URL.

Example:

https://www.example.com
have a great day, Markus

create this:
#^https://www.example.com_have a great day, Markus

show all 17 comments

Sat, 12 Oct 2024 02:01:18 +0200

Der Pepe (Hubzilla) ⁂ ⚝

pepecyb@hub.hubzilla.hu

I noticed that too and I wanted to share it here. But then I couldn't reproduce the error. But now, thanks to your post, @Markus ,I now know... yes, this always happens when the link is followed by a line break.

Workaround: Include the link in [url][/url].

---
Sent by a #Hubzilla instance to the #Fediverse

Sat, 12 Oct 2024 02:05:07 +0200

Markus

markus@hubzilla.markusgarlichs.de

@Der Pepe (Hubzilla) ⁂ ⚝ ah ok, thanks for the workaround!

Sat, 12 Oct 2024 09:53:19 +0200

Harald Eilertsen

harald@hub.volse.no

@Markus Thanks, that's a great test case. I'll add it to the bbcode and markdown tests and see if I can get it fixed.

Sat, 12 Oct 2024 12:53:14 +0200

Scott M. Stolz

scott@biztechtonics.net

Also, when viewed on other platforms, it ignores the line breaks and puts everything on one line.

Sat, 12 Oct 2024 13:35:36 +0200

Harald Eilertsen

harald@hub.volse.no

@Scott M. Stolz That's a fundamental incompatibility between BBCode and both Markdown and HTML. Both Markdown and HTML expects whitespace to be insignificant, that is, a space, newline, tab, etc are treated the same, and multiple of either is collapsed to one space char. The exception is within <pre> or Markdown code blocks. It's possible to insert a hard line break in Markdown by either ending the line with a \ or by two space chars and a newline.

BBCode on the other hand treats newlines as significant, so a single \n char will translate to a <br /> tag in HTML. At least the way it's being used by Hubzilla.

Not sure how important we feel it is to keep the existing newline handling in BBCode, or if we should align it with how Markdown and HTML operate?

It causes quite a bit of extra complexity wrt mixing Markdown and BBCode as it is now.</pre>

Sat, 12 Oct 2024 13:38:19 +0200

Jupiter Rowland

jupiter_rowland@hub.netzgemeinde.eu

@Der Pepe (Hubzilla) ⁂ ⚝ Side-effect of this: It breaks the Bookmarks app functionality. But this also means that the pesky "#^" before links is not generated.

Sat, 12 Oct 2024 16:29:11 +0200

_jayrope

jrp@hub.kliklak.net

@Der Pepe (Hubzilla) ⁂ ⚝ Same here - thanks for the url fix - however, never had this before.

Sent to the #Fediverse from my #Hubzilla instance.

Sat, 12 Oct 2024 17:36:20 +0200 last edited: Sat, 12 Oct 2024 17:36:32 +0200

Mario Vavti

mario@hub.somaton.com

@Harald Eilertsen i think that is a regresseion from the recent codeblock fix.

Not sure how important we feel it is to keep the existing newline handling in BBCode, or if we should align it with how Markdown and HTML operate?

I am afraid changing this will break tons of existing content...

Sat, 12 Oct 2024 18:30:28 +0200

Harald Eilertsen

harald@hub.volse.no

@Mario Vavti That's what I'm worried about too...

Sat, 12 Oct 2024 18:38:05 +0200

Harald Eilertsen

harald@hub.volse.no

Found the issue btw, and have submitted a merge request to fix it. The problem was that at some point, the regex for detecting URLs in the cleanup_bbcode function had been broken across two lines, which made it think that the newline was a valid character and a part of the URL.

Took a while to drill down to this one. As neither the bbcode parser, nor the markdown parser displayed the artifact on their own. The cleanup_bbcode function is only called by the Item module when a post is posted (or previewed).

This is also the code that's responsible for adding the #^ in front of URL's.

Sun, 13 Oct 2024 03:34:14 +0200

Scott M. Stolz

scott@biztechtonics.net

@Harald Eilertsen

Not sure how important we feel it is to keep the existing newline handling in BBCode, or if we should align it with how Markdown and HTML operate?

Do we send HTML or BBCode via ActivityPub?

Sun, 13 Oct 2024 16:03:10 +0200

Harald Eilertsen

harald@hub.volse.no

@Scott M. Stolz My guess would be HTML, but I'm sure @Mario Vavti has more info on that.

Sun, 13 Oct 2024 20:01:13 +0200

Scott M. Stolz

scott@biztechtonics.net

@Harald Eilertsen If it is HTML, we probably should send <pre><code> and not just <code>.

I noticed the issue when my reply had a code block and it was formatted incorrectly in a NodeBB thread.</code></code></pre>

Sun, 13 Oct 2024 20:25:21 +0200

Mario Vavti

mario@hub.somaton.com

@Scott M. Stolz we send both, HTML and text/bbcode.

Sun, 13 Oct 2024 20:30:45 +0200

Mario Vavti

mario@hub.somaton.com

@Scott M. Stolz currently a multiline codeblock is turned into <pre><code>some code</code></pre> and inline codeblock is turned into just <code></code>. Let me know if you think the latter should also be wrapped in a pre tag. I think it should not have any negative side-effects (famous last words

)

Sun, 13 Oct 2024 20:59:23 +0200

Harald Eilertsen

harald@hub.volse.no

@Mario Vavti Nah, inline code should not be wrapped in <pre> tags. That breaks the semantics of html.</pre>

Mon, 14 Oct 2024 05:41:03 +0200

Scott M. Stolz

scott@biztechtonics.net

I have to agree that inline should not have <pre> around it.

If we are sending multi-line code blocks as </pre><pre><code>, then the problem that I encountered is with NodeBB not rendering it correctly.

cc: @julian</code></pre>