Zotlabs\Thumbs in use?

2024-11-07 19:37:56

development@hubzilla.org

Harald Eilertsen wrote the following post Thu, 07 Nov 2024 19:38:13 +0100

Zotlabs\Thumbs in use?

Is any of the stuff in Zotlabs\Thumbs in use? I can't find any references to it?

If not, I'll remove it, and the dependencies that this code wants.

show all 6 comments

2024-11-07 22:12:43

Mario Vavti

mario@hub.somaton.com

Yes, those are called from Daemon\Thumbnail which is called at least in Storage/Directory and Storage/File IIRC.

2024-11-07 23:32:21

Harald Eilertsen

harald@hub.volse.no

@Mario Vavti Thanks! Found it.

2024-11-08 14:56:49

Harald Eilertsen

harald@hub.volse.no

@Mario Vavti They don't work, though... at least not the Epub thumbnailer. (I've only looked at that one so far.) The problem seems to be that calling imagejpeg() with a filename that don't end in jpg (or presumably, jpeg) fails to actually output the file. So no thumbnail is produced.

When changing the output extension from .thumb to .jpg the file is output like it should, but of course then Hubzilla won't pick it up as a thumbnail.

I see a couple of different ways around this:

Use somthing like .thumb.jpg as extension instead of just .thumb. This also means we will need to fix any code that wants to find/use the thumbnails as well.
Rewrite the code to generate the image data as a string, and then write it to the file ourselves. This will allow us to keep .thumb, but adds a little bit of extra complexity. We need to use output buffering tricks from what I can see.

I'm thinking I'll have a go at option 2 first, and see how ugly it becomes. If it's no big deal, I think that's probably the easiest.

2024-11-08 15:13:51

Harald Eilertsen

harald@hub.volse.no

Forget it... after a bit of refactoring it seems to work anyways. :)

Not that I see the thumbnails used anywhere.

2024-11-08 15:35:10

Mario Vavti

mario@hub.somaton.com

@Harald Eilertsen

Not that I see the thumbnails used anywhere

In the files app when you choose the tiles view?

2024-11-08 16:54:53

Harald Eilertsen

harald@hub.volse.no

@Mario Vavti Nah, just get a generic thumbnail.