Installing addon repos via the admin/addons page
I've been trying to clean up a bit in the library subdirectory, and as part of that; getting the PhpGit dependency managed by Composer. In itself pretty straight forward, but now adding addon repos via the admin/addons page does not work anymore. I fix an issue that I assume is an incompatibility with the newer version of the dependency, and get a bit further.
The next issue is a bug in the latest version of the PhpGit upstream project, so I fix that and
submit a patch upstream. I also patch our vendored version of the dependency (a bit dirty, but hopefully temporary) and try again.
Still it does not work!This time because the code assumes the new addon repo has a branch named 'master' and tries to list the contents of that to find the README file it seems. My addon repo that I tested against does not have a branch named master.
Getting closer, but just to make sure I decide to just switch back to dev and try with the old version of PhpGit in the library dir. ...however that does not work either! In fact, it takes me back to the original bug that I thought was because of the newer version of the library.
Iow, this functionality is already broken, and since that code hasn't seen much change for about a decade, I wonder if this ever worked.
We're able to fix it if we want, but this is still a lot of extra code and complexity that we may not really need.
I'm suggesting we ditch it! Instead I think it's worth looking for a simpler way to add addons via the admin pages. In the meantime, addon repos can still be installed via the
util/add_(addon|theme|widget)_repo scripts as before.
Any thoughts?
