No updated profile photos from other contacts

Fri, 07 Jun 2024 12:00:25 +0200

adminsforum@hubzilla.org

Tim Schlotfeldt ⚓🏳️‍🌈 wrote the following post Fri, 07 Jun 2024 12:00:46 +0200

No updated profile photos from other contacts

Sometimes I recognize that one of my contacts has changed the profile photo, but my Hubzilla site still shows the old photo.

Example:

Original posting with acutal profile photo: #^https://mastodon.social/@gavinkarlmeier/112565320987734852
The posting on my Hubzilla site with wrong (old) profile photo: #^https://hub.tschlotfeldt.de/hq/105a8baa-4526-5674-9df6-4cbd12825e6c

I did see this in the past with other account, for example one account on Friendica.

Any ideas how I can fix this?

show all 18 comments

Fri, 07 Jun 2024 12:17:06 +0200

Mario Vavti

mario@hub.somaton.com

@Tim Schlotfeldt ⚓🏳️‍🌈 you can always click "Edit connection" from the dropdown menu and then select "Refresh" from the contact tools.

Fri, 07 Jun 2024 12:33:48 +0200

Tim Schlotfeldt ⚓🏳️‍🌈

ts-new@hub.tschlotfeldt.de

@Mario Vavti Hi Mario, thank you. I did that but it never had an effect.

Fri, 07 Jun 2024 12:41:58 +0200

Mario Vavti

mario@hub.somaton.com

@Tim Schlotfeldt ⚓🏳️‍🌈 then there can be different reasons. Would be good to check the log. Also check if the webserver user has write permissions to all subfolders in /store.

Fri, 07 Jun 2024 13:14:10 +0200

Tim Schlotfeldt ⚓🏳️‍🌈

ts-new@hub.tschlotfeldt.de

I'll check that.

Sun, 09 Jun 2024 20:56:44 +0200

Tim Schlotfeldt ⚓🏳️‍🌈

ts-new@hub.tschlotfeldt.de

@Mario Vavti So, I just tried it with enabled debugging logs and tried a contact refresh. In line 3 there is an error but I don't know what that means.

1 LOG_INFO:168f09c4fc:QueueWorker.php:306:Process: PROCESSING: 7bc81e657eb90ec0 Xchan_photo
2 LOG_INFO:168f09c4fc:photo_driver.php:226:import_xchan_photo: Updating channel photo from https://files.mastodon.social/accounts/avatars/108/193/089/730/902/939/original/8ff6d582aaacad72.jpg for https://mastodon.social/users/gavinkarlmeier
3 LOG_INFO:168f09c4fc:network.php:199:z_fetch_url: z_fetch_url: error: https://files.mastodon.social/accounts/avatars/108/193/089/730/902/939/original/8ff6d582aaacad72.jpg:
4 LOG_INFO:168f09c4fc:photo_driver.php:392:import_xchan_photo: xchan: https://mastodon.social/users/gavinkarlmeier; HTTP code: 304; modified: 2024-06-09 18:43:41; URL: https://hub.tschlotfeldt.de/photo/36500f75-e5e2-4a43-98b6-8d9fb39b81f2-4
5 LOG_INFO:168f09c4fc:QueueWorker.php:312:Process: logger_stats_data cmd:Xchan_photo start:1717958621.0104 end:1717958621.0497 meta:7bc81e657eb90ec0

Mon, 10 Jun 2024 00:30:49 +0200

Harald Eilertsen

harald@hub.volse.no

@Tim Schlotfeldt ⚓🏳️‍🌈 That's not really an error, we just think it is.

Looks to me that the remote server is responding with a status 304, which means the resource was not modified since we last checked (according to the headers we sent in the request.)

The z_fetch_url function only checks that the returned status is not a redirect or an OK response, and thinks it's an error otherwise. It tries to log some useful info about the error from curl, but since curl doesn't think it's an error, there's no useful info to print.

The actual result is logged in the line below it –the fourth line in your log above. The modified timestamp may be wrong though, the log falls back to the current time if the response does not contain the last-modified header.

Mon, 10 Jun 2024 12:16:35 +0200

Mario Vavti

mario@hub.somaton.com

@Tim Schlotfeldt ⚓🏳️‍🌈 have you checked file permissions?

Mon, 10 Jun 2024 13:56:15 +0200

Tim Schlotfeldt ⚓🏳️‍🌈

ts-new@hub.tschlotfeldt.de

Hi @Mario Vavti! Unfortunately I can't find anything unusual:

[www-hubtschlotfeldtde@eckholm store]$ ls -la \[data\]/\[xchan\]/3/6/36500f75-e5e2-4a43-98b6-8d9fb39b81f2-4
-rw-r--r-- 1 www-hubtschlotfeldtde www-hubtschlotfeldtde 126658 Feb  2  2023 '[data]/[xchan]/3/6/36500f75-e5e2-4a43-98b6-8d9fb39b81f2-4'

When I hit the refresh button a new photo file will be created (downloaded?). I did this two more times, so the photos filename is now 36500f75-e5e2-4a43-98b6-8d9fb39b81f2-6.

Or is there another place where I should have to look for?

Mon, 10 Jun 2024 14:05:50 +0200

Mario Vavti

mario@hub.somaton.com

@Tim Schlotfeldt ⚓🏳️‍🌈 xxx-4, xxx-5, xxx-6 are just the different scales of the image we store. large, medium and small

www-hubtschlotfeldtde is your webserver user? You could try a chown -R yourwebserveruser:yourwebserveruser store just to make sure all folders and subfolders are writable by the webserver.

Mon, 10 Jun 2024 14:14:23 +0200

Tim Schlotfeldt ⚓🏳️‍🌈

ts-new@hub.tschlotfeldt.de

@Mario Vavti

www-hubtschlotfeldtde is your webserver user?

Yep.

You could try a chown -R yourwebserveruser:yourwebserveruser store just to make sure all folders and subfolders are writable by the webserver.

I tried it, crossed my fingers … but it didn't worked.

Mon, 10 Jun 2024 14:51:16 +0200

Mario Vavti

mario@hub.somaton.com

@Tim Schlotfeldt ⚓🏳️‍🌈 well... not entirely sure, but if there was a write permission issue, you might not be able to refresh because hubzilla thinks it is up to date already...
However you could manually reset the entries in the DB i guess.

Mon, 10 Jun 2024 15:06:35 +0200 last edited: Mon, 10 Jun 2024 15:12:12 +0200

Harald Eilertsen

harald@hub.volse.no

@Mario Vavti @Tim Schlotfeldt ⚓🏳️‍🌈 The way I read the code, and correlate with the log output, I don't think this is a file system write/permission problem. It's simply that the remote server tells us the photo has not been updates, so we don't do anything about it.

There could be many reasons for this:

The remote image has not been updated.
The remote server does not think the image has been updated.
We send the incorrect last modified time in the request to the server.

The import_xchan_photo function has a force flag that's false by default. When true, this will download the image regardless of when it was last modified.

The only place this flag seems to be used is in the cron job (Zotlabs/Daemon/Cron.php line 213). This only seems to trigger for missing photos, though.

I think setting this flag to true when the refresh action has been selected should solve the problem.

Mon, 10 Jun 2024 16:07:52 +0200

Tim Schlotfeldt ⚓🏳️‍🌈

ts-new@hub.tschlotfeldt.de

@Harald Eilertsen

I think setting this flag to true when the refresh action has been selected should solve the problem.

I can confirm. I set the force flag in the code manually. After that a refresh of the contact loaded the profile photo from the Mastodon site. @Mario Vavti

Mon, 10 Jun 2024 17:06:56 +0200

Harald Eilertsen

harald@hub.volse.no

@Tim Schlotfeldt ⚓🏳️‍🌈 Cool! Submit a patch if you can!

Mon, 10 Jun 2024 22:07:06 +0200

Tim Schlotfeldt ⚓🏳️‍🌈

ts-new@hub.tschlotfeldt.de

@Harald Eilertsen I would like to do so, but I'm not a programmer. What I did for my testings was setting the force flag directly in include/photo/photo_driver.php.

Mon, 10 Jun 2024 22:11:15 +0200

Harald Eilertsen

harald@hub.volse.no

@Tim Schlotfeldt ⚓🏳️‍🌈 Ah, ok, that can be a bit too much :) I can see if I find the correct place to set it. Unless @Mario Vavti beats me to it, of course :)

Tue, 11 Jun 2024 10:05:59 +0200

Mario Vavti

mario@hub.somaton.com

This should be #fixed with #^https://framagit.org/hubzilla/core/-/commit/4ba4b2976e71d3ba61148962eab35bedf50d140a

Tue, 11 Jun 2024 10:30:14 +0200

Harald Eilertsen

harald@hub.volse.no

@Mario Vavti Nice!